Re: Possible problem emulating movntq, movss

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 08/06/2014 12:54 PM, Jan Beulich wrote:
>>>> On 06.08.14 at 10:57, <rcojocaru@bitdefender.com> wrote:
>> We found that our HVM guests froze when trying to emulate movntq
>> instructions. The solution seems to be to replace "goto done;" with
>> "break;" at line 4191 (when handling "case 0x7f:") in
>> xen/arch/x86/x86_emulate/x86_emulate.c. Otherwise the writeback part
>> doesn't happen.
>>
>> If you're happy with the fix I can prepare a patch, otherwise please let
>> me know if we're missing something.
> 
> No, that doesn't look right: There's nothing left to be written back at
> that point (registers get updated with the instruction executed via the
> on-stack stub, and memory gets written with immediately preceding
> ops->write(). So without you being more specific about _what_ you
> see going wrong I don't think I can give further advice.

I understand. My colleague and fellow xen-devel subscriber Andrei Lutas
has found the issue and the solution, and will reply with more details.

> Furthermore what you write is kind of inconsistent: For one, opcode
> 0x7f is movq/movdq[au] rather than movntdq (admitted they're
> being handled by the same code block, but you ought to be rather
> precise here). And then the subject of your mail mentions movss, but
> the body doesn't at all - is that because you mean the same would
> apply to that other similar code block?

Indeed, my assumptions were exactly those: movq/movdq[au] is handled in
the same code block (it is, in fact, arguably the beginning of said code
block) as movntdq, and movss seems to be handled in the same manner
("goto done;" vs "break;"), and if I understood Andrei correctly, poses
the same problem.


Thanks,
Razvan Cojocaru