From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] fix Remus failover regression Date: Thu, 07 Aug 2014 08:43:12 +0100 Message-ID: <53E32E10.5090306@citrix.com> References: <1406520207-10769-1-git-send-email-yanghy@cn.fujitsu.com> <53E2D37D.4070503@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <53E2D37D.4070503@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Hongyang Yang , xen-devel@lists.xen.org Cc: Shriram Rajagopalan , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org T24gMDcvMDgvMjAxNCAwMjoxNiwgSG9uZ3lhbmcgWWFuZyB3cm90ZToKPiBQaW5nIQo+Cj4g5Zyo IDA3LzI4LzIwMTQgMTI6MDMgUE0sIFlhbmcgSG9uZ3lhbmcg5YaZ6YGTOgo+PiBjb21taXQ6IGMy YmE3MDZjCj4+IHRvb2xzL2xpYnhjOiBnb3RvIGNvcnJlY3QgbGFiZWwgb24gZXJyb3IgcGF0aHMg YnkgQW5kcmV3IENvb3Blcgo+PiBicm9rZSBSZW11cyBpbiBYZW4gNC40IG9yIGVhcmxpZXIgdmVy c2lvbnMgdGhhdCBoYXMgdGhpcyBjb21taXQKPj4gYmFja3BvcnRlZC4KPj4KPj4gV2l0aCBSZW11 cywgdGhpcyBqdW1wIGVzc2VudGlhbGx5IGRpc2NhcmRzIHRoZSBjdXJyZW50IGluY29tcGxldGUK Pj4gY2hlY2twb2ludCByZWNlaXZlZCBieSB0aGUgYmFja3VwIGFuZCByZXN0b3JlIGJhY2t1cCBm cm9tIHRoZQo+PiBsYXN0IGNvbXBsZXRlIGNoZWNrcG9pbnQuCj4+IFRoaXMgaXMgcmVxdWlyZWQg Zm9yIFJlbXVzIHRvIHdvcmsgYW5kIHRoaXMgZG9lcyBub3QgYnJlYWsgbGl2ZQo+PiBtaWdyYXRp b24uCj4+IEl0IGhhcyBiZWVuIGFyb3VuZCBzaW5jZSBYZW4gNC4wLgo+Pgo+PiBDQzogSWFuIEph Y2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4+IENDOiBJYW4gQ2FtcGJlbGwgPGlh bi5jYW1wYmVsbEBjaXRyaXguY29tPgo+PgoKSXQgaXMgZWxzZXdoZXJlIGluIHRoaXMgdGhyZWFk LCBidXQgUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIKPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j b20+Cgo+PiBDQzogU2hyaXJhbSBSYWphZ29wYWxhbiA8cnNocmlyYW1AY3MudWJjLmNhPgo+PiBT aWduZWQtb2ZmLWJ5OiBZYW5nIEhvbmd5YW5nIDx5YW5naHlAY24uZnVqaXRzdS5jb20+Cj4+IC0t LQo+PiAgIHRvb2xzL2xpYnhjL3hjX2RvbWFpbl9yZXN0b3JlLmMgfCAxMyArKysrKysrKysrKy0t Cj4+ICAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+ Cj4+IGRpZmYgLS1naXQgYS90b29scy9saWJ4Yy94Y19kb21haW5fcmVzdG9yZS5jCj4+IGIvdG9v bHMvbGlieGMveGNfZG9tYWluX3Jlc3RvcmUuYwo+PiBpbmRleCBlNzNlMGEyLi5iOWE1NmQ1IDEw MDY0NAo+PiAtLS0gYS90b29scy9saWJ4Yy94Y19kb21haW5fcmVzdG9yZS5jCj4+ICsrKyBiL3Rv b2xzL2xpYnhjL3hjX2RvbWFpbl9yZXN0b3JlLmMKPj4gQEAgLTE3ODMsMjAgKzE3ODMsMjkgQEAg aW50IHhjX2RvbWFpbl9yZXN0b3JlKHhjX2ludGVyZmFjZSAqeGNoLCBpbnQKPj4gaW9fZmQsIHVp bnQzMl90IGRvbSwKPj4KPj4gICAgICAgaWYgKCBwYWdlYnVmX2dldCh4Y2gsIGN0eCwgJnBhZ2Vi dWYsIGlvX2ZkLCBkb20pICkgewo+PiAgICAgICAgICAgUEVSUk9SKCJlcnJvciB3aGVuIGJ1ZmZl cmluZyBiYXRjaCwgZmluaXNoaW5nIik7Cj4+IC0gICAgICAgIGdvdG8gb3V0Owo+PiArICAgICAg ICAvKgo+PiArICAgICAgICAgKiBSZW11czogZGlzY2FyZCB0aGUgY3VycmVudCBpbmNvbXBsZXRl IGNoZWNrcG9pbnQgYW5kIHJlc3RvcmUKPj4gKyAgICAgICAgICogYmFja3VwIGZyb20gdGhlIGxh c3QgY29tcGxldGUgY2hlY2twb2ludC4KPj4gKyAgICAgICAgICovCj4+ICsgICAgICAgIGdvdG8g ZmluaXNoOwo+PiAgICAgICB9Cj4+ICAgICAgIG1lbXNldCgmdG1wdGFpbCwgMCwgc2l6ZW9mKHRt cHRhaWwpKTsKPj4gICAgICAgdG1wdGFpbC5pc2h2bSA9IGh2bTsKPj4gICAgICAgaWYgKCBidWZm ZXJfdGFpbCh4Y2gsIGN0eCwgJnRtcHRhaWwsIGlvX2ZkLCBtYXhfdmNwdV9pZCwgdmNwdW1hcCwK Pj4gICAgICAgICAgICAgICAgICAgICAgICBleHRfdmNwdWNvbnRleHQsIHZjcHVleHRzdGF0ZV9z aXplKSA8IDAgKSB7Cj4+ICAgICAgICAgICBFUlJPUiAoImVycm9yIGJ1ZmZlcmluZyBpbWFnZSB0 YWlsLCBmaW5pc2hpbmciKTsKPj4gLSAgICAgICAgZ290byBvdXQ7Cj4+ICsgICAgICAgIC8qCj4+ ICsgICAgICAgICAqIFJlbXVzOiBkaXNjYXJkIHRoZSBjdXJyZW50IGluY29tcGxldGUgY2hlY2tw b2ludCBhbmQgcmVzdG9yZQo+PiArICAgICAgICAgKiBiYWNrdXAgZnJvbSB0aGUgbGFzdCBjb21w bGV0ZSBjaGVja3BvaW50Lgo+PiArICAgICAgICAgKi8KPj4gKyAgICAgICAgZ290byBmaW5pc2g7 Cj4+ICAgICAgIH0KPj4gICAgICAgdGFpbGJ1Zl9mcmVlKCZ0YWlsYnVmKTsKPj4gICAgICAgbWVt Y3B5KCZ0YWlsYnVmLCAmdG1wdGFpbCwgc2l6ZW9mKHRhaWxidWYpKTsKPj4KPj4gICAgICAgZ290 byBsb2FkcGFnZXM7Cj4+Cj4+ICsgIC8qIFdpdGggUmVtdXM6IHJlc3RvcmUgZnJvbSBsYXN0IGNv bXBsZXRlIGNoZWNrcG9pbnQgKi8KPj4gICAgIGZpbmlzaDoKPj4gICAgICAgaWYgKCBodm0gKQo+ PiAgICAgICAgICAgZ290byBmaW5pc2hfaHZtOwo+Pgo+CgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK