From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC 8/9] xen: arm: support for up to 48-bit physical addressing on arm64 Date: Thu, 07 Aug 2014 16:33:53 +0100 Message-ID: <53E39C61.2050502@linaro.org> References: <3ef2b68c511f3e31de409b76757b95c78b99d750.1406728037.git.ian.campbell@citrix.com> <8541fa3183c9eae4ad5163b1d1da5f5563a3e5b2.1406728037.git.ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8541fa3183c9eae4ad5163b1d1da5f5563a3e5b2.1406728037.git.ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 07/30/2014 02:47 PM, Ian Campbell wrote: > diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h > index 9d230f3..979a41d 100644 > --- a/xen/include/asm-arm/processor.h > +++ b/xen/include/asm-arm/processor.h > @@ -84,6 +84,38 @@ > #define HCR_SWIO (_AC(1,UL)<<1) /* Set/Way Invalidation Override */ > #define HCR_VM (_AC(1,UL)<<0) /* Virtual MMU Enable */ > > +/* TCR: Stage 1 Translation Control */ > + > +#define TCR_T0SZ(x) ((x)<<0) > + > +#define TCR_IRGN0_NC (_AC(0x0,UL)<<8) > +#define TCR_IRGN0_WBWA (_AC(0x1,UL)<<8) > +#define TCR_IRGN0_WT (_AC(0x2,UL)<<8) > +#define TCR_IRGN0_WB (_AC(0x3,UL)<<8) > + > +#define TCR_ORGN0_NC (_AC(0x0,UL)<<10) > +#define TCR_ORGN0_WBWA (_AC(0x1,UL)<<10) > +#define TCR_ORGN0_WT (_AC(0x2,UL)<<10) > +#define TCR_ORGN0_WB (_AC(0x3,UL)<<10) > + > +#define TCR_SH0_NS (_AC(0x0,UL)<<12) > +#define TCR_SH0_OS (_AC(0x2,UL)<<12) > +#define TCR_SH0_IS (_AC(0x3,UL)<<12) > + > +#define TCR_TG0_4K (_AC(0x0,UL)<<14) > +#define TCR_TG0_64K (_AC(0x1,UL)<<14) > +#define TCR_TG0_16K (_AC(0x2,UL)<<14) > + > +#define TCR_PS(x) ((x)<<16) > + > +#define TCR_TBI (_AC(0x1,UL)<<20) TCR_PS and TCR_TBI are armv8 specific. I would only protect them by #ifdef CONFIG_ARM_64 The rest of the patch looks good to me. Regards, -- Julien Grall