From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int Date: Fri, 08 Aug 2014 15:26:18 +0800 Message-ID: <53E47B9A.60905@intel.com> References: <1407481204-28290-1-git-send-email-tiejun.chen@intel.com> <53E4952B020000780002A5EF@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53E4952B020000780002A5EF@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2014/8/8 15:15, Jan Beulich wrote: >>>> On 08.08.14 at 09:00, wrote: >> This shouldn't ever be negative. > > This means nothing for the actual change, and makes me imply you did > the change without checking it actually _is_ never negative in any of > the uses. > > Also please cut down your patch title prefixes (not just here) to > something reasonable. > What about this? xen:e820map: just convert nr_map with unsigned int nr_map is used to represent the amount of e820entry in e820 so it shouldn't be negative. Thanks Tiejun