From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 2/2] tools/xen-access: Print gla valid/fault information Date: Fri, 08 Aug 2014 09:07:33 +0100 Message-ID: <53E48545.90005@citrix.com> References: <1407453172-10785-1-git-send-email-tamas.lengyel@zentific.com> <1407453172-10785-2-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XFfD4-0006hz-Ec for xen-devel@lists.xenproject.org; Fri, 08 Aug 2014 08:07:34 +0000 In-Reply-To: <1407453172-10785-2-git-send-email-tamas.lengyel@zentific.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 08/08/2014 00:12, Tamas K Lengyel wrote: > Extend the print-out of the memory violations to show gla valid/fault information. > > v2: Update to new fields and change printing 1/0 to y/n. > > Signed-off-by: Tamas K Lengyel > --- > tools/tests/xen-access/xen-access.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c > index 090df5f..378b205 100644 > --- a/tools/tests/xen-access/xen-access.c > +++ b/tools/tests/xen-access/xen-access.c > @@ -566,13 +566,16 @@ int main(int argc, char *argv[]) > } > > printf("PAGE ACCESS: %c%c%c for GFN %"PRIx64" (offset %06" > - PRIx64") gla %016"PRIx64" (vcpu %d)\n", > + PRIx64") gla %016"PRIx64" (valid: %c) fault in gpt: %c gpa has gla: %c (vcpu %d)\n", As you likely need to repsin this patch, please correct %d to %u as req.vcpu_id is unsigned. ~Andrew > req.access_r ? 'r' : '-', > req.access_w ? 'w' : '-', > req.access_x ? 'x' : '-', > req.gfn, > req.offset, > req.gla, > + req.gla_valid ? 'y' : 'n', > + req.fault_in_gpt ? 'y' : 'n', > + req.fault_gla ? 'y': 'n', > req.vcpu_id); > > if ( default_access != after_first_access )