From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int Date: Fri, 08 Aug 2014 17:06:12 +0800 Message-ID: <53E49304.7030802@intel.com> References: <1407481204-28290-1-git-send-email-tiejun.chen@intel.com> <53E4952B020000780002A5EF@mail.emea.novell.com> <53E47B9A.60905@intel.com> <53E49A87020000780002A635@mail.emea.novell.com> <53E48227.9000300@intel.com> <53E4AB4E020000780002A7AB@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53E4AB4E020000780002A7AB@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2014/8/8 16:49, Jan Beulich wrote: >>>> On 08.08.14 at 09:54, wrote: >> On 2014/8/8 15:38, Jan Beulich wrote: >>>>>> On 08.08.14 at 09:26, wrote: >>>> On 2014/8/8 15:15, Jan Beulich wrote: >>>>>>>> On 08.08.14 at 09:00, wrote: >>>>>> This shouldn't ever be negative. >>>>> >>>>> This means nothing for the actual change, and makes me imply you did >>>>> the change without checking it actually _is_ never negative in any of >>>>> the uses. >>>>> >>>>> Also please cut down your patch title prefixes (not just here) to >>>>> something reasonable. >>>>> >>>> >>>> What about this? >>>> >>>> xen:e820map: just convert nr_map with unsigned int >>> >>> x86: make struct e820map's nr_map unsigned >> >> Okay. >> >>> >>>> nr_map is used to represent the amount of e820entry in e820 so it >>>> shouldn't be negative. >>> >>> You still say "shouldn't" instead of "isn't", making me still imply you >>> didn't verify that fact. I.e. I'd be fine with a suitable variant of the >> >> Maybe I'm poor to describe that main point here. >> >> x86: make struct e820map's nr_map unsigned >> >> nr_map is used to represent the amount of e820entry in e820 so its >> not always negative. > > "not always negative"? > > Based on your initial one, "This is never negative" would be fine, Will be fixed. > _provided you verified_ this to be the case. > Sorry, are you saying I need to add something in patch description, x86: make struct e820map's nr_map unsigned nr_map is used to represent the amount of e820entry in e820 so this is never negative. Note just boot one VM to confirm this is really fine. Signed-off-by: Tiejun Chen Thanks Tiejun