From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [RFC][PATCH 2/5] xen:x86: introduce a new hypercall to get RMRR mappings Date: Wed, 13 Aug 2014 08:40:16 +0800 Message-ID: <53EAB3F0.3050808@intel.com> References: <1407409371-31728-1-git-send-email-tiejun.chen@intel.com> <1407409371-31728-3-git-send-email-tiejun.chen@intel.com> <53E50CB4020000780002AB34@mail.emea.novell.com> <53E9F2AD.1090505@intel.com> <53EA2277020000780002B978@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53EA2277020000780002B978@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 2014/8/12 20:19, Jan Beulich wrote: >>>> On 12.08.14 at 12:55, wrote: >> On 2014/8/8 23:45, Jan Beulich wrote: >>>>>> On 07.08.14 at 13:02, wrote: >>>> +/* >>>> + * Returns the RMRR memory map as it was when the domain >>>> + * was started. >>>> + */ >>>> +#define XENMEM_RMRR_memory_map 26 >>>> +typedef struct e820map rmrr_e820_t; >>>> +DEFINE_XEN_GUEST_HANDLE(rmrr_e820_t); >>> >>> Again just as a general remark: What in the world does the "e820" >>> in here mean? >> >> I will redefine a struct to represent this to avoid any confusion. > > And just to avoid another needless round: The term RMRR shouldn't > be in the hypercall public interface definitions either. This needs to > be properly abstracted. > Without such a term RMRR I can't figure out what definition should be better as you expect, I guess you already have a better case so please share it to avoid further discussion. Thanks Tiejun