xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [V0 PATCH] PVH: Don't set EFER_SCE for pvh guest
@ 2014-08-22  3:14 Mukesh Rathor
  2014-08-22  9:57 ` Roger Pau Monné
  0 siblings, 1 reply; 2+ messages in thread
From: Mukesh Rathor @ 2014-08-22  3:14 UTC (permalink / raw)
  To: jbeulich, roger.pau; +Cc: xen-devel

Just like NX is guest managed, SCE should be too. Remove setting of
the EFER_SCE for pvh guest.

Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
---
 xen/arch/x86/hvm/hvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index d40c48e..7ec618b 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2283,7 +2283,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
     {
         v->arch.hvm_vcpu.hcall_64bit = 1;    /* PVH 32bitfixme. */
         /* This is for hvm_long_mode_enabled(v). */
-        v->arch.hvm_vcpu.guest_efer = EFER_SCE | EFER_LMA | EFER_LME;
+        v->arch.hvm_vcpu.guest_efer = EFER_LMA | EFER_LME;
         return 0;
     }
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [V0 PATCH] PVH: Don't set EFER_SCE for pvh guest
  2014-08-22  3:14 [V0 PATCH] PVH: Don't set EFER_SCE for pvh guest Mukesh Rathor
@ 2014-08-22  9:57 ` Roger Pau Monné
  0 siblings, 0 replies; 2+ messages in thread
From: Roger Pau Monné @ 2014-08-22  9:57 UTC (permalink / raw)
  To: Mukesh Rathor, jbeulich; +Cc: xen-devel

On 22/08/14 05:14, Mukesh Rathor wrote:
> Just like NX is guest managed, SCE should be too. Remove setting of
> the EFER_SCE for pvh guest.
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

FYI, FreeBSD PVH was already setting SCE on it's own during BSP/AP
initialization.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-22  9:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22  3:14 [V0 PATCH] PVH: Don't set EFER_SCE for pvh guest Mukesh Rathor
2014-08-22  9:57 ` Roger Pau Monné

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).