xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Yang Z Zhang <yang.z.zhang@intel.com>
Cc: LiangX Z Li <liangx.z.li@intel.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Donald D Dugger <donald.d.dugger@intel.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: VT-d flush timeout
Date: Fri, 22 Aug 2014 08:58:24 +0100	[thread overview]
Message-ID: <53F71440020000780002C8C9@mail.emea.novell.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E0AB6B0BC@SHSMSX104.ccr.corp.intel.com>

>>> On 22.08.14 at 09:49, <yang.z.zhang@intel.com> wrote:
> Jan Beulich wrote on 2014-08-22:
>>>>> On 21.08.14 at 05:16, <yang.z.zhang@intel.com> wrote:
>>> Jan Beulich wrote on 2014-08-19:
>>>>>>> "Zhang, Yang Z" <yang.z.zhang@intel.com> 08/19/14 3:34 AM >>>
>>>>> My only concern is that, for QI flush, the spin time relies on the
>>>>> length of the queue. I am not sure whether 1s is enough for worst
>>>>> case and I think we should remove the 1s in QI flush. And I think
>>>>> this also the same reason for Linux don't use timeout mechanism in
>>>>> QI
>> flush.
>>>> 
>>>> First of all I think both Linux and Xen in the majority of cases
>>>> waits for completion of just individual queue entries. I.e. I'm not
>>>> sure if the practical worst case really is equal to the theoretical
>>>> one. And
>>> 
>>> This is my guessing from Linux's implementation but may wrong.
>> 
>> Which is why we ask for you (the VT-d maintainer) to, as a first step,
>> supply a patch limiting the spinning time to a value smaller than the
>> current on, just enough to cover real requirements. The second step
> 
> This doesn't answer my question. I still don't see why a smaller value 
> helps.

Because it reduces the impact the currently large value would have
in misbehaving cases? Don clearly indicated to me that it shouldn't
be a big deal to reduce the current timeout, so I really don't see what
all this argument is about.

Jan

  reply	other threads:[~2014-08-22  7:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  2:01 VT-d flush timeout Zhang, Yang Z
2014-08-18  9:47 ` Andrew Cooper
2014-08-18 12:48 ` Jan Beulich
2014-08-19  1:34   ` Zhang, Yang Z
2014-08-19 13:02     ` Jan Beulich
2014-08-21  3:16       ` Zhang, Yang Z
2014-08-22  7:33         ` Jan Beulich
2014-08-22  7:49           ` Zhang, Yang Z
2014-08-22  7:58             ` Jan Beulich [this message]
2014-08-22  8:05               ` Zhang, Yang Z
2014-08-25 17:21                 ` Dugger, Donald D
2014-09-25  1:02       ` Dong, Eddie
2014-09-25  8:55         ` Jan Beulich
2014-09-25 10:44           ` Andrew Cooper
2014-09-25 10:55             ` Jan Beulich
2014-09-25 10:56               ` Andrew Cooper
2014-09-25 11:48                 ` Jan Beulich
2014-09-25 21:21                   ` Tian, Kevin
2014-09-25 23:23           ` Dong, Eddie
2014-09-26  1:07             ` Zhang, Yang Z
2014-09-26  6:30             ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F71440020000780002C8C9@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=donald.d.dugger@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=liangx.z.li@intel.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).