From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH RESEND v7 3/9] vnuma hook to debug-keys u
Date: Fri, 22 Aug 2014 10:13:51 +0100
Message-ID: <53F725EF020000780002C92D@mail.emea.novell.com>
References: <1408597829-21135-1-git-send-email-ufimtseva@gmail.com>
	<20140821161907.GC18265@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140821161907.GC18265@laptop.dumpdata.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Elena Ufimtseva <ufimtseva@gmail.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com, lccycc123@gmail.com, george.dunlap@eu.citrix.com, msw@linux.com, dario.faggioli@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 21.08.14 at 18:19, <konrad.wilk@oracle.com> wrote:
> On Thu, Aug 21, 2014 at 01:10:23AM -0400, Elena Ufimtseva wrote:
>> @@ -389,6 +389,34 @@ static void dump_numa(unsigned char key)
>>  
>>  		for_each_online_node(i)
>>  			printk("    Node %u: %u\n", i, page_num_node[i]);
>> +
>> +		if ( d->vnuma ) {
>> +			printk("    Domain has %u vnodes, %u vcpus\n", d->vnuma->nr_vnodes, d->max_vcpus);

Long line.

>> +			for ( i = 0; i < d->vnuma->nr_vnodes; i++ ) {
> 
> That '{'
> needs to be on another line.
> 
>> +
>> +				err = snprintf(keyhandler_scratch, 12, "%u", d->vnuma->vnode_to_pnode[i]);
>> +				if ( err < 0 || d->vnuma->vnode_to_pnode[i] == NUMA_NO_NODE)
> 
> You need a space at the end, so 'NUMA_NO_NODE )'
> 
>> +					snprintf(keyhandler_scratch, 3, "???");
>> +				printk("        vnode %3u - pnode %s,", i, keyhandler_scratch);
>> +
>> +				printk(" %"PRIu64" MB, ",
>> +					(d->vnuma->vmemrange[i].end - d->vnuma->vmemrange[i].start) >> 20);
>> +
>> +				printk("vcpu nrs: ");
>> +				for ( j = 0, n = 0; j < d->max_vcpus; j++ ) {
> 
> { on its own line.
>> +					if ( d->vnuma->vcpu_to_vnode[j] == i ) {
> 
> Ditto

And, Elena, I have been pointing out these coding style issues
on previous iterations.

Jan