From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH V2] Update pvSCSI protocol description Date: Mon, 25 Aug 2014 15:27:29 +0200 Message-ID: <53FB39C1.9090602@suse.com> References: <1408968810-19172-1-git-send-email-jgross@suse.com> <53FB4927020000780002D367@suse.com> <53FB3166.1070903@suse.com> <53FB52DC020000780002D404@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53FB52DC020000780002D404@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org On 08/25/2014 03:14 PM, Jan Beulich wrote: >>>> On 25.08.14 at 14:51, wrote: >> On 08/25/2014 02:33 PM, Jan Beulich wrote: >>>>>> On 25.08.14 at 14:13, <"jgross@suse.com".non-mime.internet> wrote: >>>> + uint8_t nr_segments; /* Number of pieces of scatter-gather */ >>>> +#define VSCSIIF_SG_GRANT 0x80 /* flag: SG elements via grant page */ >>>> + /* nr_segments counts grant pages with >>>> + SG elements. >>>> + usable if "feature-sg-grant" set */ >>> >>> Is that really accurate? If said value is to go into nr_segments, >>> all such requests would have to have exactly 128 "grant pages >>> with SG elements". >> >> Have you read the comment just above the #define of VSCSIIF_ACT_SCSI_CDB >> describing the interface? > > Yes, but > - people looking here don't necessarily also look there > - it being correct there doesn't provide room for it getting > described incorrectly here Aah, now I understand your comment. I'll adjust the comment. Juergen