From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC/WIP 2/4] libxc: treat domain in SHUTDOWN_kexec state as being already suspended Date: Mon, 25 Aug 2014 15:01:59 +0100 Message-ID: <53FB41D7.20602@citrix.com> References: <1408974146-6519-1-git-send-email-vkuznets@redhat.com> <1408974146-6519-3-git-send-email-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XLuqr-0008JN-AS for xen-devel@lists.xenproject.org; Mon, 25 Aug 2014 14:02:29 +0000 In-Reply-To: <1408974146-6519-3-git-send-email-vkuznets@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vitaly Kuznetsov , xen-devel@lists.xenproject.org Cc: Andrew Jones , David Vrabel , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 25/08/14 14:42, Vitaly Kuznetsov wrote: > Signed-off-by: Vitaly Kuznetsov > --- > tools/libxc/xc_domain_save.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c > index 42c4752..5423bfa 100644 > --- a/tools/libxc/xc_domain_save.c > +++ b/tools/libxc/xc_domain_save.c > @@ -366,7 +366,8 @@ static int suspend_and_state(int (*suspend)(void*), void* data, > } > > if ( (xc_domain_getinfo(xch, dom, 1, info) != 1) || > - !info->shutdown || (info->shutdown_reason != SHUTDOWN_suspend) ) > + !info->shutdown || ((info->shutdown_reason != SHUTDOWN_suspend) && > + (info->shutdown_reason != SHUTDOWN_kexec)) ) This will break PV unless you mandate that SHUTDOWN_kexec follows the same principle as SHUTDOWN_suspend, i.e. stashing the start info mfn in rdx. Best alter the comment in public/sched.h when adding SHUTDOWN_kexec. ~Andrew