From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <JGross@suse.com>
Cc: keir@xen.org, ian.campbell@citrix.com, ian.jackson@eu.citrix.com,
tim@xen.org, xen-devel@lists.xen.org, david.vrabel@citrix.com
Subject: Re: [PATCH V2] Update pvSCSI protocol description
Date: Mon, 25 Aug 2014 14:14:36 +0100 [thread overview]
Message-ID: <53FB52DC020000780002D404@mail.emea.novell.com> (raw)
In-Reply-To: <53FB3166.1070903@suse.com>
>>> On 25.08.14 at 14:51, <JGross@suse.com> wrote:
> On 08/25/2014 02:33 PM, Jan Beulich wrote:
>>>>> On 25.08.14 at 14:13, <"jgross@suse.com".non-mime.internet> wrote:
>>> + uint8_t nr_segments; /* Number of pieces of scatter-gather */
>>> +#define VSCSIIF_SG_GRANT 0x80 /* flag: SG elements via grant page */
>>> + /* nr_segments counts grant pages with
>>> + SG elements.
>>> + usable if "feature-sg-grant" set */
>>
>> Is that really accurate? If said value is to go into nr_segments,
>> all such requests would have to have exactly 128 "grant pages
>> with SG elements".
>
> Have you read the comment just above the #define of VSCSIIF_ACT_SCSI_CDB
> describing the interface?
Yes, but
- people looking here don't necessarily also look there
- it being correct there doesn't provide room for it getting
described incorrectly here
Jan
next prev parent reply other threads:[~2014-08-25 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 12:13 [PATCH V2] Update pvSCSI protocol description Juergen Gross
2014-08-25 12:33 ` Jan Beulich
[not found] ` <53FB4927020000780002D367@suse.com>
2014-08-25 12:51 ` Juergen Gross
2014-08-25 13:14 ` Jan Beulich [this message]
2014-08-25 13:27 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB52DC020000780002D404@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).