xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	stefan.bader@canonical.com, toshi.kani@hp.com,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	konrad.wilk@oracle.com, ville.syrjala@linux.intel.com,
	hpa@zytor.com, x86@kernel.org
Subject: Re: [Xen-devel] [PATCH 3/3] Support Xen pv-domains using PAT
Date: Tue, 26 Aug 2014 11:59:41 +0100	[thread overview]
Message-ID: <53FC689D.7020507@citrix.com> (raw)
In-Reply-To: <1409033783-12136-4-git-send-email-jgross@suse.com>

On 26/08/14 07:16, Juergen Gross wrote:
> With the dynamical mapping between cache modes and pgprot values it is now
> possible to use all cache modes via the Xen hypervisor PAT settings in a
> pv domain.
> 
> All to be done is to read the PAT configuration MSR and set up the translation
> tables accordingly.
[...]
> +void xen_init_cache_types(void)
> +{
> +	pat_init_cache_modes();
> +}

No need to introduce xen_init_cache_types(), just call
pat_init_cache_modes() directly.

>  void xen_set_pat(u64 pat)
>  {
> -	/* We expect Linux to use a PAT setting of
> -	 * UC UC- WC WB (ignoring the PAT flag) */
> -	WARN_ON(pat != 0x0007010600070106ull);
> +	xen_init_cache_types();
>  }

Remove xen_set_pat() and remove the special-cased handling of the PAT
MSR from xen_write_msr_safe().

David

  reply	other threads:[~2014-08-26 10:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  6:16 [PATCH 0/3] x86: Full support of PAT Juergen Gross
2014-08-26  6:16 ` [PATCH 1/3] x86: Make page cache mode a real type Juergen Gross
2014-08-26 19:44   ` Toshi Kani
2014-08-27  4:07     ` [Xen-devel] " Juergen Gross
2014-08-26  6:16 ` [PATCH 2/3] x86: Enable PAT to use cache mode translation tables Juergen Gross
2014-08-26 19:45   ` Toshi Kani
2014-08-28 23:21   ` Toshi Kani
2014-08-29  4:08     ` Juergen Gross
2014-08-26  6:16 ` [PATCH 3/3] Support Xen pv-domains using PAT Juergen Gross
2014-08-26 10:59   ` David Vrabel [this message]
2014-08-26 12:54     ` [Xen-devel] " Juergen Gross
2014-08-26 18:48 ` [PATCH 0/3] x86: Full support of PAT Andy Lutomirski
2014-08-26 20:08   ` Toshi Kani
2014-08-26 20:23     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FC689D.7020507@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.bader@canonical.com \
    --cc=toshi.kani@hp.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).