xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel@lists.xenproject.org,
	Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH RFC/WIP 1/4] Introduce SHUTDOWN_kexec shutdown reason
Date: Tue, 26 Aug 2014 14:25:34 +0100	[thread overview]
Message-ID: <53FC8ACE.60102@citrix.com> (raw)
In-Reply-To: <53FC9C4D020000780002D995@mail.emea.novell.com>

On 26/08/14 13:40, Jan Beulich wrote:
>>>> On 26.08.14 at 12:16, <david.vrabel@citrix.com> wrote:
>> On 25/08/14 14:42, Vitaly Kuznetsov wrote:
>>> --- a/xen/include/public/sched.h
>>> +++ b/xen/include/public/sched.h
>>> @@ -158,7 +158,8 @@ DEFINE_XEN_GUEST_HANDLE(sched_watchdog_t);
>>>  #define SHUTDOWN_suspend    2  /* Clean up, save suspend info, kill.        
>>  */
>>>  #define SHUTDOWN_crash      3  /* Tell controller we've crashed.            
>>  */
>>>  #define SHUTDOWN_watchdog   4  /* Restart because watchdog time expired.    
>>  */
>>> -#define SHUTDOWN_MAX        4  /* Maximum valid shutdown reason.             
>> */
>>> +#define SHUTDOWN_kexec      5  /* Soft-reboot for kexec.                     
>> */
>>
>> I agree with Jan on the name.
>>
>> The documentation also needs to be expanded.  It should be clear that
>> this hypercall may return in a new domain.
> 
> Perhaps s/may/will/ ?

Yes, but only on success.

David

  reply	other threads:[~2014-08-26 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 13:42 [PATCH RFC/WIP 0/4] toolstack-based approach to pvhvm guest kexec Vitaly Kuznetsov
2014-08-25 13:42 ` [PATCH RFC/WIP 1/4] Introduce SHUTDOWN_kexec shutdown reason Vitaly Kuznetsov
2014-08-25 14:03   ` Jan Beulich
2014-08-26 10:16   ` David Vrabel
2014-08-26 12:40     ` Jan Beulich
2014-08-26 13:25       ` David Vrabel [this message]
2014-08-25 13:42 ` [PATCH RFC/WIP 2/4] libxc: treat domain in SHUTDOWN_kexec state as being already suspended Vitaly Kuznetsov
2014-08-25 14:01   ` Andrew Cooper
2014-08-25 13:42 ` [PATCH RFC/WIP 3/4] libxl: add SHUTDOWN_kexec state support Vitaly Kuznetsov
2014-08-25 13:42 ` [PATCH RFC/WIP 4/4] libxl: rebuild guest domains on kexec Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FC8ACE.60102@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=drjones@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).