From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH RFC 1/7] xen: Relocate mem_access and mem_event into common. Date: Tue, 26 Aug 2014 14:34:05 +0100 Message-ID: <53FCA8ED020000780002DA05@mail.emea.novell.com> References: <1408699832-13325-1-git-send-email-tamas.lengyel@zentific.com> <1408699832-13325-2-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1408699832-13325-2-git-send-email-tamas.lengyel@zentific.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, andres@lagarcavilla.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org >>> On 22.08.14 at 11:30, wrote: > In preparation to add support for ARM LPAE mem_event, relocate mem_access > and mem_event into common Xen code. This patch makes no functional changes > to the X86 side, for ARM mem_event and mem_access functions are just > placeholder stubs. "Makes no functional changes" is a little too weak a statement to efficiently review such a big patch: Please clarify how much of the non-benign changes (like asm/ -> xen/ include file path adjustments) is really just code movement vs. where you needed to actually alter the code. > xen/arch/x86/domctl.c | 2 +- > xen/arch/x86/hvm/hvm.c | 61 +--- > xen/arch/x86/mm/Makefile | 2 - > xen/arch/x86/mm/hap/nested_ept.c | 2 +- > xen/arch/x86/mm/hap/nested_hap.c | 2 +- > xen/arch/x86/mm/mem_access.c | 133 -------- > xen/arch/x86/mm/mem_event.c | 705 -------------------------------------- > xen/arch/x86/mm/mem_paging.c | 2 +- > xen/arch/x86/mm/mem_sharing.c | 2 +- > xen/arch/x86/mm/p2m-pod.c | 2 +- > xen/arch/x86/mm/p2m-pt.c | 2 +- > xen/arch/x86/mm/p2m.c | 2 +- > xen/arch/x86/x86_64/compat/mm.c | 4 +- > xen/arch/x86/x86_64/mm.c | 4 +- > xen/common/Makefile | 2 + > xen/common/domain.c | 1 + > xen/common/mem_access.c | 137 ++++++++ > xen/common/mem_event.c | 707 +++++++++++++++++++++++++++++++++++++++ > xen/common/memory.c | 62 ++++ > xen/include/asm-arm/mm.h | 1 - > xen/include/asm-x86/hvm/hvm.h | 6 - > xen/include/asm-x86/mem_access.h | 39 --- > xen/include/asm-x86/mem_event.h | 82 ----- > xen/include/asm-x86/mm.h | 2 - > xen/include/xen/mem_access.h | 58 ++++ > xen/include/xen/mem_event.h | 141 ++++++++ > xen/include/xen/mm.h | 6 + > 27 files changed, 1128 insertions(+), 1041 deletions(-) This changes maintainership of a couple of files without also adjusting ./MAINTAINERS. > delete mode 100644 xen/arch/x86/mm/mem_access.c > delete mode 100644 xen/arch/x86/mm/mem_event.c > create mode 100644 xen/common/mem_access.c > create mode 100644 xen/common/mem_event.c > delete mode 100644 xen/include/asm-x86/mem_access.h > delete mode 100644 xen/include/asm-x86/mem_event.h > create mode 100644 xen/include/xen/mem_access.h > create mode 100644 xen/include/xen/mem_event.h Doesn't git have a mode where moves can be reflected as ordinary diffs rather than as deletes/creates? While I'm not sure my scripts would cope with applying such a patch, it surely would make review easier (and perhaps even eliminate the question raised at the top). Jan