From: "Jan Beulich" <JBeulich@suse.com>
To: Elena Ufimtseva <ufimtseva@gmail.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Li Yechen <lccycc123@gmail.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Matt Wilson <msw@linux.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v8 3/9] vnuma hook to debug-keys u
Date: Tue, 26 Aug 2014 16:46:22 +0100 [thread overview]
Message-ID: <53FCC7EE020000780002DBE6@mail.emea.novell.com> (raw)
In-Reply-To: <CAEr7rXjMhAx7i8cSiQkcPJeGXL0bBTkNgtmaM+nTLcWeADxf0w@mail.gmail.com>
>>> On 26.08.14 at 17:36, <ufimtseva@gmail.com> wrote:
> On Tue, Aug 26, 2014 at 11:29 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> Actually I'm afraid Konrad's comment (and me agreeing to it)
>> misguided you here: The function is currently written in Linux
>> style, so Linux style is what the changes should be in. I.e.
>> opening curly braces on the same line as the end of their
>> control construct, and no blanks inside outermost parentheses
>> of control constructs.
>>
>> However, the comment regarding overly long lines was correct
>> (and sadly still stands), and there are indentation issues too.
>
> This file has both coding styles and every my attempt to match it fails :)
Not really, its Linux style with perhaps a few mistakes.
> Can I make changes to numa.c so it will be formatted like any other
> file if there
> is no reason to have it formatted in this way?
If you feel up to making it have entirely uniform style, just go for it.
Jan
next prev parent reply other threads:[~2014-08-26 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:45 [PATCH v8 3/9] vnuma hook to debug-keys u Elena Ufimtseva
2014-08-26 7:45 ` [PATCH v8 4/9] libxc: Introduce xc_domain_setvnuma to set vNUMA Elena Ufimtseva
2014-08-27 20:31 ` Konrad Rzeszutek Wilk
2014-08-26 7:45 ` [PATCH v8 5/9] libxl: vnuma types declararion Elena Ufimtseva
2014-08-26 7:45 ` [PATCH v8 6/9] libxl: build numa nodes memory blocks Elena Ufimtseva
2014-08-26 7:45 ` [PATCH v8 7/9] libxc: allocate domain memory for vnuma enabled Elena Ufimtseva
2014-08-26 7:45 ` [PATCH v8 8/9] libxl: vnuma nodes placement bits Elena Ufimtseva
2014-08-26 7:45 ` [PATCH v8 9/9] libxl: vnuma topology configuration parser and doc Elena Ufimtseva
2014-08-26 15:29 ` [PATCH v8 3/9] vnuma hook to debug-keys u Jan Beulich
2014-08-26 15:36 ` Elena Ufimtseva
2014-08-26 15:46 ` Jan Beulich [this message]
2014-08-26 15:56 ` Elena Ufimtseva
2014-08-27 20:26 ` Konrad Rzeszutek Wilk
2014-08-27 20:33 ` Elena Ufimtseva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCC7EE020000780002DBE6@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=lccycc123@gmail.com \
--cc=msw@linux.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=ufimtseva@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).