From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v8 3/9] vnuma hook to debug-keys u
Date: Tue, 26 Aug 2014 16:46:22 +0100
Message-ID: <53FCC7EE020000780002DBE6@mail.emea.novell.com>
References: <1409039106-955-1-git-send-email-ufimtseva@gmail.com>
	<53FCC40B020000780002DB89@mail.emea.novell.com>
	<CAEr7rXjMhAx7i8cSiQkcPJeGXL0bBTkNgtmaM+nTLcWeADxf0w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAEr7rXjMhAx7i8cSiQkcPJeGXL0bBTkNgtmaM+nTLcWeADxf0w@mail.gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Elena Ufimtseva <ufimtseva@gmail.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Li Yechen <lccycc123@gmail.com>, George Dunlap <george.dunlap@eu.citrix.com>, Matt Wilson <msw@linux.com>, Dario Faggioli <dario.faggioli@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 26.08.14 at 17:36, <ufimtseva@gmail.com> wrote:
> On Tue, Aug 26, 2014 at 11:29 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> Actually I'm afraid Konrad's comment (and me agreeing to it)
>> misguided you here: The function is currently written in Linux
>> style, so Linux style is what the changes should be in. I.e.
>> opening curly braces on the same line as the end of their
>> control construct, and no blanks inside outermost parentheses
>> of control constructs.
>>
>> However, the comment regarding overly long lines was correct
>> (and sadly still stands), and there are indentation issues too.
> 
> This file has both coding styles and every my attempt to match it fails :)

Not really, its Linux style with perhaps a few mistakes.

> Can I make changes to numa.c so it will be formatted like any other
> file if there
> is no reason to have it formatted in this way?

If you feel up to making it have entirely uniform style, just go for it.

Jan