From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] tools/libxl: Initialise both parts of
 ctx->sigchld_selfpipe[] to -1
Date: Wed, 27 Aug 2014 00:34:14 +0100
Message-ID: <53FD1976.90202@citrix.com>
References: <1408366957-19860-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1408366957-19860-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 18/08/2014 14:02, Andrew Cooper wrote:
> Otherwise, if it is not used, libxl_ctx_free() will close fd 0.
>
> Reported-by: Alex Bligh <alex@alex.org.uk>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---

Ping?  This is a rather nasty bug which needs fixing in 4.4 as well.

>  tools/libxl/libxl.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 3526539..a1e0b5e 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -71,6 +71,7 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
>      ctx->childproc_user = 0;
>          
>      ctx->sigchld_selfpipe[0] = -1;
> +    ctx->sigchld_selfpipe[1] = -1;
>      libxl__ev_fd_init(&ctx->sigchld_selfpipe_efd);
>  
>      /* The mutex is special because we can't idempotently destroy it */