From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings Date: Wed, 27 Aug 2014 09:37:45 +0800 Message-ID: <53FD3669.3070705@intel.com> References: <1409050980-21933-1-git-send-email-tiejun.chen@intel.com> <1409050980-21933-4-git-send-email-tiejun.chen@intel.com> <53FC774D.8000501@citrix.com> <53FC9BB1020000780002D986@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53FC9BB1020000780002D986@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, Andrew Cooper , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 2014/8/26 20:37, Jan Beulich wrote: >>>> On 26.08.14 at 14:02, wrote: >> On 26/08/14 12:02, Tiejun Chen wrote: >>> + case XENMEM_reserved_device_memory_map: >>> + { >>> + struct xen_mem_reserved_device_memory_map map; >>> + XEN_GUEST_HANDLE(xen_mem_reserved_device_memory_t) buffer; >>> + XEN_GUEST_HANDLE_PARAM(xen_mem_reserved_device_memory_t) buffer_param; >>> + unsigned int i = 0; >>> + static struct xen_mem_reserved_device_memory rmrr_map; >> >> This absolutely must not be static, as I have indicated twice before. > > Indeed, you should be reading what you're being told, and not > submit new patch versions without having addressed (by altering > the patch or addressing the comment verbally) previous comments. This is my typo. I already see Andrew's comment to work that without any memory allocation, but really forget to remove 'static'. > For example, I had also asked you to adjust your patch titles, yet Are you sure? I recheck all e-mails you replied to me but I don't find this comment. > they still come in the same bogus form (namely with colons rather > than slashes as prefix separators - this ones should e.g. start with > "xen/x86:", albeit I personally dislike the xen/ prefix and tend to > strip it). Anyway, I think you'd like to change all titles as follows: 1> xen/vtd/rmrr: export acpi_rmrr_units 2> xen/vtd/rmrr: introduce acpi_rmrr_unit_entries 3> xen/x86: define a new hypercall to get RMRR mappings 4> tools/libxc: introduce hypercall for xc_reserved_device_memory_map 5> tools/libxc: check if mmio BAR is out of RMRR mappings 6> hvm_info_table: introduce nr_reserved_device_memory_map 7> xen/x86: support xc_reserved_device_memory_map in compat case 8> tools/firmware/hvmloader: introduce hypercall for xc_reserved_device_memory_map 9> tools/firmware/hvmloader: check to reserve RMRR mappings in e820 10> xen/vtd: make USB RMRR mapping safe > > It is for that reason that I didn't comment on the last two or so > iterations of your patch series - the effort the repeated pointing > out of issues causes just makes it sit at the very end of the list of > things needing looking at). > I always read to address all comments but looks I may be missing something, I think I should check carefully. Thanks Tiejun > Jan > >