From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v4][PATCH 5/9] hvm_info_table: introduce nr_reserved_device_memory_map Date: Wed, 27 Aug 2014 09:54:30 +0800 Message-ID: <53FD3A56.5020205@intel.com> References: <1408702186-24432-1-git-send-email-tiejun.chen@intel.com> <1408702186-24432-6-git-send-email-tiejun.chen@intel.com> <1409085519.28009.39.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409085519.28009.39.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: kevin.tian@intel.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 2014/8/27 4:38, Ian Campbell wrote: > On Fri, 2014-08-22 at 18:09 +0800, Tiejun Chen wrote: >> libxc can expose how many reserved device memory entries >> hvmloader should get. > > "get" in what sense? > >> And '0' means that doesn't exist so >> we can skip this check. > > Which check? > > The code is trivial enough that I guess it is correct, and I don't > expect a full explanation here (since I assume that comes in some future > patch) but an accurate/meaningful quick indication would be useful here. > Okay, I think I should describe this case explicitly as follows: hvm_info_table: introduce nr_reserved_device_memory_map libxc can expose how many reserved device memory entries to notify hvmloader. Then hvmloader would check if those reserved memory overlap current memory range in e820. Note if nr_reserved_device_memory_map is '0', this means we have any reserved device memory so we can skip that check. Signed-off-by: Tiejun Chen Thanks Tiejun