Re: [PATCH RFC 1/7] xen: Relocate mem_access and mem_event into common.

["Jan Beulich" <JBeulich@suse.com>]

>>> On 26.08.14 at 18:30, <tamas.lengyel@zentific.com> wrote:
> On Tue, Aug 26, 2014 at 5:32 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
>> >>> On 26.08.14 at 16:42, <tamas.lengyel@zentific.com> wrote:
>> > On Tue, Aug 26, 2014 at 3:34 PM, Jan Beulich <JBeulich@suse.com> wrote:
>> >> >>> On 22.08.14 at 11:30, <tamas.lengyel@zentific.com> wrote:
>> >> >  xen/arch/x86/domctl.c            |   2 +-
>> >> >  xen/arch/x86/hvm/hvm.c           |  61 +---
>> >> >  xen/arch/x86/mm/Makefile         |   2 -
>> >> >  xen/arch/x86/mm/hap/nested_ept.c |   2 +-
>> >> >  xen/arch/x86/mm/hap/nested_hap.c |   2 +-
>> >> >  xen/arch/x86/mm/mem_access.c     | 133 --------
>> >> >  xen/arch/x86/mm/mem_event.c      | 705
>> >> --------------------------------------
>> >> >  xen/arch/x86/mm/mem_paging.c     |   2 +-
>> >> >  xen/arch/x86/mm/mem_sharing.c    |   2 +-
>> >> >  xen/arch/x86/mm/p2m-pod.c        |   2 +-
>> >> >  xen/arch/x86/mm/p2m-pt.c         |   2 +-
>> >> >  xen/arch/x86/mm/p2m.c            |   2 +-
>> >> >  xen/arch/x86/x86_64/compat/mm.c  |   4 +-
>> >> >  xen/arch/x86/x86_64/mm.c         |   4 +-
>> >> >  xen/common/Makefile              |   2 +
>> >> >  xen/common/domain.c              |   1 +
>> >> >  xen/common/mem_access.c          | 137 ++++++++
>> >> >  xen/common/mem_event.c           | 707
>> >> +++++++++++++++++++++++++++++++++++++++
>> >> >  xen/common/memory.c              |  62 ++++
>> >> >  xen/include/asm-arm/mm.h         |   1 -
>> >> >  xen/include/asm-x86/hvm/hvm.h    |   6 -
>> >> >  xen/include/asm-x86/mem_access.h |  39 ---
>> >> >  xen/include/asm-x86/mem_event.h  |  82 -----
>> >> >  xen/include/asm-x86/mm.h         |   2 -
>> >> >  xen/include/xen/mem_access.h     |  58 ++++
>> >> >  xen/include/xen/mem_event.h      | 141 ++++++++
>> >> >  xen/include/xen/mm.h             |   6 +
>> >> >  27 files changed, 1128 insertions(+), 1041 deletions(-
>> >> This changes maintainership of a couple of files without also
>> >> adjusting ./MAINTAINERS.
>> >>
>> >
>> > The only code that is shifted is the mem_event/mem_access code and I
>> don't
>> > see entries for them in MAINTAINERS, so I think they would still just
>> fall
>> > under "THE REST". If there are other maintainership changes caused by
>> this
>> > patch that I'm unaware of please let me know and I'll adjust the
>> > MAINTAINERS.
>>
>> No, the current files fall under
>>
>> X86 MEMORY MANAGEMENT
>> M:      Tim Deegan <tim@xen.org>
>> S:      Supported
>> F:      xen/arch/x86/mm/
> 
> Ah, I see. It's also not clear to me who would be the new maintainer or if
> Tim would remain the maintainer of these files under /common.

My take on it would be that maintainership shouldn't change when
files get moved around. But of course that's something primarily
Tim will have to decide.

Jan