From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC v2 01/12] xen: Relocate mem_access and
 mem_event into common.
Date: Wed, 27 Aug 2014 10:17:40 -0400
Message-ID: <53FDE884.3090606@linaro.org>
References: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409148400-14810-2-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409148400-14810-2-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:
> In preparation to add support for ARM LPAE mem_event, relocate mem_access,
> mem_event and auxiliary functions into common Xen code.
> This patch makes no functional changes to the X86 side, for ARM mem_event
> and mem_access functions are just defined as placeholder stubs, and are
> actually enabled later in the series.
>
> Edits that are only header path adjustments:
>     xen/arch/x86/domctl.c
>     xen/arch/x86/mm/hap/nested_ept.c
>     xen/arch/x86/mm/hap/nested_hap.c
>     xen/arch/x86/mm/mem_paging.c
>     xen/arch/x86/mm/mem_sharing.c
>     xen/arch/x86/mm/p2m-pod.c
>     xen/arch/x86/mm/p2m-pt.c
>     xen/arch/x86/mm/p2m.c
>     xen/arch/x86/x86_64/compat/mm.c
>     xen/arch/x86/x86_64/mm.c
>
> Makefile adjustments for new/removed code:
>     xen/common/Makefile
>     xen/arch/x86/mm/Makefile
>
> Relocated prepare_ring_for_helper and destroy_ring_for_helper functions:
>     xen/include/xen/mm.h
>     xen/common/memory.c
>     xen/include/asm-x86/hvm/hvm.h
>     xen/arch/x86/hvm/hvm.c
>
> Code movement of mem_event and mem_access with required ifdef wrappers
> added to only compile with CONFIG_X86:

As you have created new files. Why not adding a HAS_MEM_ACCESS option 
(as we did for the device tree and kexec)?

It will avoid most of you "ifdef CONFIG_X86" in common code and compile 
files only when it required.

Regards,

-- 
Julien Grall