From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v11 01/14] arch/arm: add consistency check to REMOVE p2m changes Date: Wed, 27 Aug 2014 10:46:59 -0400 Message-ID: <53FDEF63.8010004@linaro.org> References: <1408912207-28146-1-git-send-email-avanzini.arianna@gmail.com> <1408912207-28146-2-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1408912207-28146-2-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini , xen-devel@lists.xen.org Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com, andrii.tseglytskyi@globallogic.com List-Id: xen-devel@lists.xenproject.org Hi Arianna, On 24/08/14 16:29, Arianna Avanzini wrote: > Currently, the REMOVE case of the switch in apply_p2m_changes() > does not perform any consistency check on the mapping to be removed. > More in detail, the code does not check if the guest address to be > unmapped is actually mapped to the machine address given as a > parameter. > This commit adds the above-described consistency check to the REMOVEHi > path of apply_p2m_changes() and lets a warning be emitted when trying > to remove a non-existent mapping. This is instrumental to one of the > following commits, which implements the possibility to trigger the > removal of p2m ranges via the memory_mapping DOMCTL for ARM. > > Signed-off-by: Arianna Avanzini > Acked-by: Stefano Stabellini > Cc: Dario Faggioli > Cc: Paolo Valente Reviewed-by: Julien Grall Regards, -- Julien Grall