From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC v2 03/12] xen/mem_event: Relax error condition on debug builds Date: Wed, 27 Aug 2014 12:39:36 -0400 Message-ID: <53FE09C8.6060401@linaro.org> References: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de> <1409148400-14810-4-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409148400-14810-4-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org Hello Tamas, On 27/08/14 10:06, Tamas K Lengyel wrote: > A faulty tool stack can brick a debug hypervisor. Unpleasant while dev/test. > > Suggested-by: Andres Lagar Cavilla > Signed-off-by: Tamas K Lengyel > --- > xen/common/mem_event.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/xen/common/mem_event.c b/xen/common/mem_event.c > index e22b78e..8be32e1 100644 > --- a/xen/common/mem_event.c > +++ b/xen/common/mem_event.c > @@ -279,7 +279,11 @@ void mem_event_put_request(struct domain *d, > if ( current->domain != d ) > { > req->flags |= MEM_EVENT_FLAG_FOREIGN; > - ASSERT( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) ); > +#ifndef NDEBUG > + if ( !(req->flags & MEM_EVENT_FLAG_VCPU_PAUSED) ) > + printk(XENLOG_G_WARNING > + "VCPU was not paused.\n"); NIT: Can't your write the message on the previous line? Regards, -- Julien Grall