From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC v2 09/12] xen/arm: Data abort exception
 (R/W) mem_events.
Date: Wed, 27 Aug 2014 13:01:52 -0400
Message-ID: <53FE0F00.1010308@linaro.org>
References: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409148400-14810-10-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409148400-14810-10-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:
>   /*
>    * Lookup the MFN corresponding to a domain's PFN.
>    *
>    * There are no processor functions to do a stage 2 only lookup therefore we
>    * do a a software walk.
> + *
> + * [IN]:  d      Domain
> + * [IN]:  paddr  IPA
> + * [IN]:  a      (Optional) Update PTE access permission
> + * [OUT]: t      (Optional) Return PTE type
>    */
> -paddr_t p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)
> +paddr_t p2m_lookup(struct domain *d,
> +    paddr_t paddr,
> +    p2m_access_t *a,
> +    p2m_type_t *t)

The indentation looks wrong here.

>   {
>       struct p2m_domain *p2m = &d->arch.p2m;
> -    lpae_t pte, *first = NULL, *second = NULL, *third = NULL;
> +    lpae_t pte, *pte_loc, *first = NULL, *second = NULL, *third = NULL;
>       paddr_t maddr = INVALID_PADDR;
>       paddr_t mask;
>       p2m_type_t _t;
> @@ -167,20 +251,20 @@ paddr_t p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)
>
>       *t = p2m_invalid;
>
> -    spin_lock(&p2m->lock);
> -

If you need a version with the lock already taken, please introduce a 
new function (i.e p2m_lookup_locked or smth else) rather than move the 
lock in every caller.

Regards,

-- 
Julien Grall