From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough Date: Thu, 28 Aug 2014 08:56:26 +0800 Message-ID: <53FE7E3A.7050907@intel.com> References: <1408584508-5946-1-git-send-email-tiejun.chen@intel.com> <1408584508-5946-3-git-send-email-tiejun.chen@intel.com> <20140821161649.GA18265@laptop.dumpdata.com> <53F6978C.9080600@intel.com> <20140824111206.GB9561@redhat.com> <53FAC70F.1080201@intel.com> <53FBF5BD.6060104@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53FBF5BD.6060104@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: "Michael S. Tsirkin" Cc: xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org >>>>>> + */ >>>>>> + dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), >>>>>> + "xen-igd-passthrough-isa-bridge"); >>>>>> + if (dev) { >>>>>> + r = xen_host_pci_device_get(&hdev, 0, 0, PCI_DEVFN(0x1f, >>>>>> 0), 0); >>>>>> + if (!r) { >>>>>> + pci_config_set_vendor_id(dev->config, hdev.vendor_id); >>>>>> + pci_config_set_device_id(dev->config, hdev.device_id); >>> >>> Can you, instead, implement the reverse logic, probing >>> the card and supplying the correct device id for PCH? >>> >> >> Here what is your so-called reverse logic as I already asked you >> previously? Do you mean I should list all PCHs with a combo illustrated >> with the vendor/device id in advance? Then look up if we can find a > > Michael, > Ping. Thanks Tiejun > Could you explain this exactly? Then I can try follow-up your idea ASAP > if this is necessary and possible. > > Thanks > Tiejun > >> matched PCH? If yes, what is that benefit you expect in passthrough >> case? Shouldn't we pass these info to VM directly in passthrough case? >> >> Thanks >> Tiejun >> >> >> > > >