From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v7 2/2] x86/viridian: Add partition time reference counter MSR support Date: Thu, 28 Aug 2014 09:01:16 +0100 Message-ID: <53FEFDEC020000780002E866@mail.emea.novell.com> References: <1409154270-5693-1-git-send-email-paul.durrant@citrix.com> <1409154270-5693-3-git-send-email-paul.durrant@citrix.com> <53FE1D17020000780002E356@mail.emea.novell.com> <9AAE0902D5BC7E449B7C8E4E778ABCD042CC56@AMSPEX01CL01.citrite.net> <53FEF76B020000780002E7BF@mail.emea.novell.com> <9AAE0902D5BC7E449B7C8E4E778ABCD04344EE@AMSPEX01CL01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD04344EE@AMSPEX01CL01.citrite.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: "Keir (Xen.org)" , Ian Campbell , Christoph Egger , "xen-devel@lists.xen.org" , StefanoStabellini , Ian Jackson List-Id: xen-devel@lists.xenproject.org >>> On 28.08.14 at 09:55, wrote: > Yes, that would be sufficient but I thought a cast would make it more > obvious. I don't particularly care though. Are you ok with the cast as it is > in the v8 patch? Hmm, you used a cast _and_ 1000ul. I'm fine with that (i.e. no need to resubmit), but it's clearly redundant (i.e. I may edit it before committing). Jan