From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: ian.jackson@eu.citrix.com, tim@xen.org,
Chunyan Liu <cyliu@suse.com>,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] tools: (lib)xl: remove stray uses of build_info->u.pv.{kernel, ramdisk, cmdline}
Date: Thu, 28 Aug 2014 16:45:08 -0400 [thread overview]
Message-ID: <53FF94D4.2070000@linaro.org> (raw)
In-Reply-To: <5477f99d000d8ade8329b70df5283a5c0bf912c0.1409257521.git.ian.campbell@citrix.com>
Hi Ian,
On 28/08/14 16:25, Ian Campbell wrote:
> The commit 11dffa2359e8 "xen: pass kernel initrd to qemu" deprecated these in
> favour of build_info->{kernel,ramdisk,cmdline} but missed a couple of uses.
>
> The ARM case breaks guest boot by omitting the command line from the DTB while
> the xl SXP one is mostly cosmetic.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Reviewed-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-08-28 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 20:25 [PATCH] tools: (lib)xl: remove stray uses of build_info->u.pv.{kernel, ramdisk, cmdline} Ian Campbell
2014-08-28 20:45 ` Julien Grall [this message]
2014-08-28 21:01 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF94D4.2070000@linaro.org \
--to=julien.grall@linaro.org \
--cc=cyliu@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).