From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 08/21] xen/arm: Initialize the virtual
 GIC later
Date: Fri, 29 Aug 2014 14:57:27 -0400
Message-ID: <5400CD17.5060909@linaro.org>
References: <1406818852-31856-1-git-send-email-julien.grall@linaro.org>	<1406818852-31856-9-git-send-email-julien.grall@linaro.org>
	<CAH_mUMNc67VKtRdLf0oMyKN4UJhoKmP2n_b4=Z3WU945bBt-Mg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1XNRMd-0006do-Io
	for xen-devel@lists.xenproject.org; Fri, 29 Aug 2014 18:57:35 +0000
Received: by mail-qg0-f41.google.com with SMTP id i50so2716457qgf.14
	for <xen-devel@lists.xenproject.org>;
	Fri, 29 Aug 2014 11:57:33 -0700 (PDT)
In-Reply-To: <CAH_mUMNc67VKtRdLf0oMyKN4UJhoKmP2n_b4=Z3WU945bBt-Mg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On 29/08/14 09:09, Andrii Tseglytskyi wrote:
> Hi Julien,

Hi Andrii,

> Here I got 32 lines for 3 SPIs
>
> And this will break checking for IRQ validity in
> xen/arch/arm/irq.c:route_irq_to_guest() call. I will not be able to
> use IRQ with number greater than 63.
>
> Can this be handled somehow? Or maybe it is already handled and I
> missed something ?

You will have to modify the function for your purpose. If you plan to 
PIRQ == VIRQ every time, you could do smth like:

d->arch.vgic.nr_spis = gic_number_lines() - 32;

I assume, you already modified vgic_allocate_irq to return directly the 
pirq, and do nothing in vgic_free_irq.

Regards,

-- 
Julien Grall