From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v11 02/14] arch/arm: unmap partially-mapped memory regions Date: Fri, 29 Aug 2014 15:19:22 -0400 Message-ID: <5400D23A.3070403@linaro.org> References: <1408912207-28146-1-git-send-email-avanzini.arianna@gmail.com> <1408912207-28146-3-git-send-email-avanzini.arianna@gmail.com> <53FE08EA.3010006@linaro.org> <20140828091902.GA862@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140828091902.GA862@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com, andrii.tseglytskyi@globallogic.com List-Id: xen-devel@lists.xenproject.org On 28/08/14 05:19, Arianna Avanzini wrote: > On Wed, Aug 27, 2014 at 12:35:54PM -0400, Julien Grall wrote: >> Hi Arianna, > > Hello! Hi Arianna, > Thank you for the correction and for pointing that corner case out. Since I > have to send a new version perhaps I'll try to handle also the case you > mentioned. Just to see if I understood things correctly: the correct behavior > would be to leave the mapping already existing at the end of the range as it > is? The main point is too unmap only what you have mapped during the call of apply_p2m_changes. Otherwise you may get spurious warning message on Xen console and/or remove mapping that you haven't mapped. But, for the latter case the mapping would have been override if the call was succeeded. Regards, -- Julien Grall