From: Julien Grall <julien.grall@linaro.org>
To: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v5] xen: arm: introduce uImage probe function for Dom0
Date: Fri, 29 Aug 2014 16:51:13 -0400 [thread overview]
Message-ID: <5400E7C1.3070407@linaro.org> (raw)
In-Reply-To: <1409223261-15656-1-git-send-email-oleksandr.dmytryshyn@globallogic.com>
Hi Oleksandr,
On 28/08/14 06:54, Oleksandr Dmytryshyn wrote:
> #ifdef CONFIG_ARM_64
> /*
> * Check if the image is a 64-bit Image.
> @@ -398,6 +467,8 @@ int kernel_probe(struct kernel_info *info)
> rc = kernel_zimage64_probe(info, start, size);
> if (rc < 0)
> #endif
> + rc = kernel_uimage_probe(info, start, size);
> + if(rc < 0 )
NIT: the coding style is:
if ( rc < 0 )
It looks like the other if in this function don't respect the coding
style. I wouldn't resend a new version of this patch this small NIT.
Maybe Ian can fix it when it will be applied?
Anyway:
Reviewed-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-08-29 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 10:54 [PATCH v5] xen: arm: introduce uImage probe function for Dom0 Oleksandr Dmytryshyn
2014-08-29 20:51 ` Julien Grall [this message]
2014-09-08 11:10 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5400E7C1.3070407@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=oleksandr.dmytryshyn@globallogic.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).