From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v5] xen: arm: introduce uImage probe
 function for Dom0
Date: Fri, 29 Aug 2014 16:51:13 -0400
Message-ID: <5400E7C1.3070407@linaro.org>
References: <1409223261-15656-1-git-send-email-oleksandr.dmytryshyn@globallogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409223261-15656-1-git-send-email-oleksandr.dmytryshyn@globallogic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Oleksandr,

On 28/08/14 06:54, Oleksandr Dmytryshyn wrote:
>   #ifdef CONFIG_ARM_64
>   /*
>    * Check if the image is a 64-bit Image.
> @@ -398,6 +467,8 @@ int kernel_probe(struct kernel_info *info)
>       rc = kernel_zimage64_probe(info, start, size);
>       if (rc < 0)
>   #endif
> +        rc = kernel_uimage_probe(info, start, size);
> +    if(rc < 0 )

NIT: the coding style is:

if ( rc < 0 )

It looks like the other if in this function don't respect the coding 
style. I wouldn't resend a new version of this patch this small NIT. 
Maybe Ian can fix it when it will be applied?


Anyway:

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall