From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC v2 08/12] xen/arm: Add mem_event domctl
 and mem_access memop.
Date: Fri, 29 Aug 2014 16:57:02 -0400
Message-ID: <5400E91E.20904@linaro.org>
References: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409148400-14810-9-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409148400-14810-9-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:
> +    case XEN_DOMCTL_mem_event_op:
> +        ret = mem_event_domctl(d, &domctl->u.mem_event_op,
> +                               guest_handle_cast(u_domctl, void));
> +        copyback = 1;
> +    break;

The code for this domctl is exactly the same on x86. Therefore, I would 
move it in common/domctl.c.

Of course, you will have to protected with an #ifdef HAVE_MEMACCESS or 
whatever define used to know when mem event is supported for the platform.
> +
> +    case XENMEM_access_op:
> +        rc = mem_access_memop(op, guest_handle_cast(arg, xen_mem_access_op_t));
> +        break;

Same remark here.

-- 
Julien Grall