Re: [PATCH v12 02/14] arch/arm: unmap partially-mapped memory regions

[Julien Grall <julien.grall@linaro.org>]

Hi Arianna,

On 30/08/14 12:29, Arianna Avanzini wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 8f83d17..96d7dd8 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -440,6 +440,14 @@ static bool_t is_mapping_aligned(const paddr_t start_gpaddr,
>   #define P2M_ONE_PROGRESS_NOP   0x1
>   #define P2M_ONE_PROGRESS       0x10
>
> +/* Helpers to lookup the properties of each level */
> +const paddr_t level_sizes[] =
> +    { ZEROETH_SIZE, FIRST_SIZE, SECOND_SIZE, THIRD_SIZE };
> +const paddr_t level_masks[] =
> +    { ZEROETH_MASK, FIRST_MASK, SECOND_MASK, THIRD_MASK };
> +const paddr_t level_shifts[] =
> +    { ZEROETH_SHIFT, FIRST_SHIFT, SECOND_SHIFT, THIRD_SHIFT };
> +

If you made those variables global, you should add static.

It doesn't seem that the other patch of this series depends on this 
patch. Assuming there is no other modifications in series, I think you 
can resend it stand-alone.

Regards,

-- 
Julien Grall