From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 03/15] xen: Relocate mem_event_op domctl
 and access_op memop into common.
Date: Mon, 01 Sep 2014 14:11:37 -0400
Message-ID: <5404B6D9.2020108@linaro.org>
References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409581329-2607-4-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 01/09/14 10:21, Tamas K Lengyel wrote:
> diff --git a/xen/common/memory.c b/xen/common/memory.c
> index cc8a3d0..4e530bf 100644
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -25,6 +25,7 @@
>   #include <asm/hardirq.h>
>   #include <asm/p2m.h>
>   #include <xen/numa.h>
> +#include <xen/mem_access.h>
>   #include <public/memory.h>
>   #include <xsm/xsm.h>
>   #include <xen/trace.h>
> @@ -969,6 +970,10 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDL=
E_PARAM(void) arg)
>   =

>           break;
>   =

> +    case XENMEM_access_op:
> +        rc =3D mem_access_memop(cmd, guest_handle_cast(arg, xen_mem_acce=
ss_op_t));
> +        break;
> +

Every patch should be able to compile without requiring a future patch.
This is very useful when we need to bisect the tree.

Actually I got the following error:

In file included from /home/julieng/works/xen/xen/include/asm/system.h:6:0,
                 from /home/julieng/works/xen/xen/include/xen/list.h:11,
                 from /home/julieng/works/xen/xen/include/xen/mm.h:32,
                 from memory.c:13:
/home/julieng/works/xen/xen/include/public/arch-arm.h:196:41: error: unknow=
n type name =91__guest_handle_xen_mem_access_op_t=92
 #define XEN_GUEST_HANDLE_PARAM(name)    __guest_handle_ ## name
                                         ^
/home/julieng/works/xen/xen/include/xen/mem_access.h:36:22: note: in expans=
ion of macro =91XEN_GUEST_HANDLE_PARAM=92
                      XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg)
                      ^
memory.c: In function =91do_memory_op=92:
memory.c:974:9: error: implicit declaration of function =91mem_access_memop=
=92 [-Werror=3Dimplicit-function-declaration]
         rc =3D mem_access_memop(cmd, guest_handle_cast(arg, xen_mem_access=
_op_t));
         ^
memory.c:974:9: error: nested extern declaration of =91mem_access_memop=92 =
[-Werror=3Dnested-externs]

Regards,

-- =

Julien Grall