From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 15/15] tools/tests: Enable xen-access on
	ARM
Date: Mon, 01 Sep 2014 17:26:37 -0400
Message-ID: <5404E48D.8080109@linaro.org>
References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de>
	<1409581329-2607-16-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409581329-2607-16-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 01/09/14 10:22, Tamas K Lengyel wrote:
> diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-access/Makefile
> index 65eef99..698355c 100644
> --- a/tools/tests/xen-access/Makefile
> +++ b/tools/tests/xen-access/Makefile
> @@ -7,9 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
>   CFLAGS += $(CFLAGS_libxenguest)
>   CFLAGS += $(CFLAGS_xeninclude)
>
> -TARGETS-y :=
> -TARGETS-$(CONFIG_X86) += xen-access
> -TARGETS := $(TARGETS-y)
> +TARGETS := xen-access

I would move the definition of HAS_MEM_ACCESS from arch/*/Rules.mk to 
config/*.mk and use the defition here to build or not xen-access.

> @@ -520,7 +551,7 @@ int main(int argc, char *argv[])
>
>               /* Unregister for every event */
>               rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, ~0ull, 0);
> -            rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, 0,
> +            rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, GUEST_RAM_BASE_PFN,
>                                      xenaccess->domain_info->max_pages);

ARM may contains multiple banks non-contiguous banks. On Xen 4.5, there 
is 2 banks with a hole (see GUEST_RAM{0,1}_* in 
xen/include/public/arch-arm.h).

This change won't work with guest using more than 3G of RAM.

Regards,

-- 
Julien Grall