xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/NMI: allow passing just "watchdog" again
Date: Wed, 3 Sep 2014 13:32:02 +0100	[thread overview]
Message-ID: <54070A42.4070001@citrix.com> (raw)
In-Reply-To: <54072487020000780003042F@mail.emea.novell.com>

On 03/09/14 13:24, Jan Beulich wrote:
> This capability got inadvertently lost in commit 3ea2ba980a ("x86/NMI:
> allow processing unknown NMIs when watchdog is enabled") due to an
> oversight of mine.
>
> Reported-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/nmi.c
> +++ b/xen/arch/x86/nmi.c
> @@ -49,6 +49,12 @@ bool_t watchdog_force = 0;
>  
>  static void __init parse_watchdog(char *s)
>  {
> +    if ( !*s )
> +    {
> +        opt_watchdog = 1;
> +        return;
> +    }
> +
>      switch ( parse_bool(s) )
>      {
>      case 0:
>
>
>

      reply	other threads:[~2014-09-03 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 16:25 [PATCH v3] x86/NMI: Allow processing unknown NMIs when watchdog is enabled Ross Lagerwall
2014-08-28 14:07 ` Andrew Cooper
2014-09-01 13:27   ` Ross Lagerwall
2014-09-01 14:51     ` Jan Beulich
2014-09-03 12:24       ` [PATCH] x86/NMI: allow passing just "watchdog" again Jan Beulich
2014-09-03 12:32         ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54070A42.4070001@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).