From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
David Scott <dave.scott@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com,
david.vrabel@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] linux_gntshr_munmap: munmap takes a length, not a page count
Date: Wed, 3 Sep 2014 15:15:49 +0100 [thread overview]
Message-ID: <54072295.2000407@citrix.com> (raw)
In-Reply-To: <1409752879.23789.29.camel@kazak.uk.xensource.com>
On 03/09/14 15:01, Ian Campbell wrote:
> On Mon, 2014-09-01 at 13:16 +0100, David Scott wrote:
>> This fixes a bug where if a client shares more than 1 page, the
>> munmap call fails to clean up everything. A process which does
>> a lot of sharing and unsharing can run out of resources.
>
> The doc comment on xc_gntshr_munmap does say count is in pages, so your
> change is correct but all of the in tree callers seem to pass a number
> of bytes not a number of pages. i.e. everything in tools/libvchan passes
> n*PAGE_SIZE.
>
> So I don't think this change is complete without also updating those.
Would the corrent non-ABI/API-breaking fix be to just update the
documentation?
David
next prev parent reply other threads:[~2014-09-03 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 12:16 [PATCH] linux_gntshr_munmap: munmap takes a length, not a page count David Scott
2014-09-03 0:24 ` Stefano Stabellini
2014-09-03 14:01 ` Ian Campbell
2014-09-03 14:15 ` David Vrabel [this message]
2014-09-03 14:17 ` Ian Campbell
2014-09-03 14:21 ` David Vrabel
2014-09-03 14:31 ` Ian Campbell
2014-09-03 14:38 ` Andrew Cooper
2014-09-03 15:48 ` Dave Scott
2014-09-03 16:49 ` Dave Scott
2014-09-03 17:34 ` [PATCH v2] " David Scott
2014-09-10 14:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54072295.2000407@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=dave.scott@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).