From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] linux_gntshr_munmap: munmap takes a length, not a page count Date: Wed, 3 Sep 2014 15:15:49 +0100 Message-ID: <54072295.2000407@citrix.com> References: <1409573807-15801-1-git-send-email-dave.scott@citrix.com> <1409752879.23789.29.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XPBLq-0007yH-Id for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 14:15:58 +0000 In-Reply-To: <1409752879.23789.29.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , David Scott Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, david.vrabel@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 03/09/14 15:01, Ian Campbell wrote: > On Mon, 2014-09-01 at 13:16 +0100, David Scott wrote: >> This fixes a bug where if a client shares more than 1 page, the >> munmap call fails to clean up everything. A process which does >> a lot of sharing and unsharing can run out of resources. > > The doc comment on xc_gntshr_munmap does say count is in pages, so your > change is correct but all of the in tree callers seem to pass a number > of bytes not a number of pages. i.e. everything in tools/libvchan passes > n*PAGE_SIZE. > > So I don't think this change is complete without also updating those. Would the corrent non-ABI/API-breaking fix be to just update the documentation? David