From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] linux_gntshr_munmap: munmap takes a length,
 not a page count
Date: Wed, 3 Sep 2014 15:21:12 +0100
Message-ID: <540723D8.2040709@citrix.com>
References: <1409573807-15801-1-git-send-email-dave.scott@citrix.com>	
	<1409752879.23789.29.camel@kazak.uk.xensource.com>	
	<54072295.2000407@citrix.com>
	<1409753864.3323.2.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1XPBRB-0000GB-ND
	for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 14:21:29 +0000
In-Reply-To: <1409753864.3323.2.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, David Scott <dave.scott@citrix.com>, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 03/09/14 15:17, Ian Campbell wrote:
> On Wed, 2014-09-03 at 15:15 +0100, David Vrabel wrote:
>> On 03/09/14 15:01, Ian Campbell wrote:
>>> On Mon, 2014-09-01 at 13:16 +0100, David Scott wrote:
>>>> This fixes a bug where if a client shares more than 1 page, the
>>>> munmap call fails to clean up everything. A process which does
>>>> a lot of sharing and unsharing can run out of resources.
>>>
>>> The doc comment on xc_gntshr_munmap does say count is in pages, so your
>>> change is correct but all of the in tree callers seem to pass a number
>>> of bytes not a number of pages. i.e. everything in tools/libvchan passes
>>> n*PAGE_SIZE.
>>>
>>> So I don't think this change is complete without also updating those.
>>
>> Would the corrent non-ABI/API-breaking fix be to just update the
>> documentation?
> 
> libxc doesn't have a stable API or ABI.

xc_gntshr_*() really should be part of a separate libxc-for-domu that
does have a stable ABI.  But since it isn't yet...

> My thinking in this case was that @count being pages was consistent with
> other related functions in the API and also avoids issues of what to do
> if count%4096 != 0.

...this sounds reasonable.

David