From: Julien Grall <julien.grall@linaro.org>
To: Suriyan Ramasami <suriyan.r@gmail.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Cc: ian.jackson@citrix.com, Tim Deegan <tim@xen.org>,
keir@xen.org, Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410)
Date: Wed, 03 Sep 2014 14:25:43 -0400 [thread overview]
Message-ID: <54075D27.1060002@linaro.org> (raw)
In-Reply-To: <CANoR_OBGsa+C3D8SHDp=hRtmZ7G1=gz0=x5ixq5+d7uthuH78w@mail.gmail.com>
Hello Suriyan,
On 03/09/14 13:55, Suriyan Ramasami wrote:
> On the same train of thought, it would seem that EXYNOS5_MCT_BASE
> should also be extracted from the DT (in function exynos5_init_time).
Sounds a good things to modify.
> Also, I realized that the PLATFORM_START for the exynos5410 is thus:
> PLATFORM_START(exynos5, "SAMSUNG EXYNOS5")
> I believe it should instead be:
> PLATFORM_START(exynos5410, "SAMSUNG EXYNOS5410")
It looks like the platform you've introduced doesn't contain exyno5410
specific code. Why would you rename to exynos5410?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-09-03 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 23:19 [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410) Suriyan Ramasami
2014-08-21 22:21 ` Ian Campbell
2014-08-25 21:45 ` Suriyan Ramasami
2014-08-25 22:06 ` Suriyan Ramasami
2014-08-26 17:34 ` Ian Campbell
2014-08-26 21:01 ` Ian Campbell
2014-08-27 19:27 ` Suriyan Ramasami
2014-09-03 10:03 ` Ian Campbell
2014-09-03 17:55 ` Suriyan Ramasami
2014-09-03 18:25 ` Julien Grall [this message]
2014-09-03 19:07 ` Suriyan Ramasami
2014-09-03 19:15 ` Julien Grall
[not found] ` <1409821081.15505.44.camel@kazak.uk.xensource.com>
2014-09-04 15:44 ` Suriyan Ramasami
2014-09-04 15:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54075D27.1060002@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=suriyan.r@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).