From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410) Date: Wed, 03 Sep 2014 14:25:43 -0400 Message-ID: <54075D27.1060002@linaro.org> References: <1408490361-308-1-git-send-email-suriyan.r@gmail.com> <1409086912.28009.43.camel@citrix.com> <1409738581.14940.3.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suriyan Ramasami , Ian Campbell Cc: ian.jackson@citrix.com, Tim Deegan , keir@xen.org, Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Hello Suriyan, On 03/09/14 13:55, Suriyan Ramasami wrote: > On the same train of thought, it would seem that EXYNOS5_MCT_BASE > should also be extracted from the DT (in function exynos5_init_time). Sounds a good things to modify. > Also, I realized that the PLATFORM_START for the exynos5410 is thus: > PLATFORM_START(exynos5, "SAMSUNG EXYNOS5") > I believe it should instead be: > PLATFORM_START(exynos5410, "SAMSUNG EXYNOS5410") It looks like the platform you've introduced doesn't contain exyno5410 specific code. Why would you rename to exynos5410? Regards, -- Julien Grall