From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410) Date: Wed, 03 Sep 2014 15:15:43 -0400 Message-ID: <540768DF.8070305@linaro.org> References: <1408490361-308-1-git-send-email-suriyan.r@gmail.com> <1409086912.28009.43.camel@citrix.com> <1409738581.14940.3.camel@citrix.com> <54075D27.1060002@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suriyan Ramasami Cc: keir@xen.org, Ian Campbell , Tim Deegan , "xen-devel@lists.xen.org" , Jan Beulich , ian.jackson@citrix.com List-Id: xen-devel@lists.xenproject.org On 03/09/14 15:07, Suriyan Ramasami wrote: > The .compatible is exynos5410_dt_compat which lists > "samsung,exynos5410". Hence, I wanted to make the whole PLATFORM > platform specific to the exynos5410. > Now, rethinking what you have said, I believe as all of this is > generic code, the .compatible should then be exynos5_dt_compat, thus: > PLATFORM_START(exynos5, "SAMSUNG EXYNOS5") > .compatible = exynos5_dt_compat, > and not, .compatible = exynos5410_dt_compat as it is now. > > I believe this is what you were suggesting? In which case when more > SoCs are added, we just add the corresponding string in > exynos5_dt_compat. Would that be the correct interpretation? Yes. Regards, -- Julien Grall