From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 15/15] tools/tests: Enable xen-access on
 ARM
Date: Wed, 03 Sep 2014 13:27:01 -0700
Message-ID: <54077995.6020200@linaro.org>
References: <1409581329-2607-1-git-send-email-tklengyel@sec.in.tum.de>	<1409581329-2607-16-git-send-email-tklengyel@sec.in.tum.de>	<5404E48D.8080109@linaro.org>
	<CAErYnsi7GL5S8EOAKciVh3pzQJuetxwCu0JR+Ma+rphA-M7HeQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAErYnsi7GL5S8EOAKciVh3pzQJuetxwCu0JR+Ma+rphA-M7HeQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jan Beulich <jbeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 02/09/14 05:15, Tamas K Lengyel wrote:
> On Mon, Sep 1, 2014 at 11:26 PM, Julien Grall <julien.grall@linaro.org
> <mailto:julien.grall@linaro.org>> wrote:
>     On 01/09/14 10:22, Tamas K Lengyel wrote:
>
>         diff --git a/tools/tests/xen-access/__Makefile
>         b/tools/tests/xen-access/__Makefile
>         index 65eef99..698355c 100644
>         --- a/tools/tests/xen-access/__Makefile
>         +++ b/tools/tests/xen-access/__Makefile
>         @@ -7,9 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
>            CFLAGS += $(CFLAGS_libxenguest)
>            CFLAGS += $(CFLAGS_xeninclude)
>
>         -TARGETS-y :=
>         -TARGETS-$(CONFIG_X86) += xen-access
>         -TARGETS := $(TARGETS-y)
>         +TARGETS := xen-access
>
>
>     I would move the definition of HAS_MEM_ACCESS from arch/*/Rules.mk
>     to config/*.mk and use the defition here to build or not xen-access.
>
>
> I'm not a fan of that approach. How about this:

What is the problem with this solution? xen-access should be compiled 
when Xen has HAS_MEM_ACCESS=y.
As you enabled HAS_MEM_ACCESS by default when the architecture is 
supported, using TARGETS-$(HAS_MEM_ACCESS) += xen-access will make the 
support for a new architecture easier.

Anyway, I will let the maintainers decide what is the best solution.

Regards,

-- 
Julien Grall