From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Dave Scott <dave.scott@citrix.com>
Subject: Re: [PATCH 2/2] xen/gntalloc: safely delete grefs in add_grefs() undo path
Date: Mon, 8 Sep 2014 18:37:54 +0100 [thread overview]
Message-ID: <540DE972.2000507@citrix.com> (raw)
In-Reply-To: <54063C9A.9010503@oracle.com>
On 02/09/14 22:54, Boris Ostrovsky wrote:
> On 09/02/2014 10:21 AM, David Vrabel wrote:
>> If a gref could not be added (perhaps because the limit has been
>> reached or there are no more grant references available). The undo
>> path may crash because __del_gref() frees the gref while it is being
>> used for a list iteration.
>
> Need to fix commit message above.
>
>>
>> A comment suggests that using list_for_each_entry() is safe since the
>> gref isn't removed from the list being iterated over, but it is freed
>> and thus list_for_each_entry_safe() must be used.
>
> I don't read the comment in the code as if it implied anything about
> safety.
>
> Other than that, for both patches
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Applied to stable/for-linus-3.17-b.
Thanks
David
prev parent reply other threads:[~2014-09-08 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 14:21 [PATCH 0/2] xen/gntalloc: fix oopses after running out of grant refs David Vrabel
2014-09-02 14:21 ` [PATCH 1/2] xen/gntalloc: fix oops after runnning " David Vrabel
2014-09-02 14:21 ` [PATCH 2/2] xen/gntalloc: safely delete grefs in add_grefs() undo path David Vrabel
2014-09-02 21:54 ` Boris Ostrovsky
2014-09-08 17:37 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540DE972.2000507@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dave.scott@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).