From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [PATCH v2] xen/arm: Correctly support WARN_ON
Date: Mon, 08 Sep 2014 12:24:08 -0700 [thread overview]
Message-ID: <540E0258.8040702@linaro.org> (raw)
In-Reply-To: <540E0128.8070506@linaro.org>
On 08/09/14 12:19, Julien Grall wrote:
>>
>> OOI what is the size increase of the final (stripped) binary with this
>> patch?
>
> I compared the file xen/xen and on both arm32/arm64 the binary is
> smaller of about 2%.
>
> I think this is because previously gcc wasn't merge the string when
> BUG_ON was used in inline function.
BTW this series won't work correctly because of XSA-102 on ARM64 when
WARN_ON/BUG_ON/ASSERT is used in startup code.
This is because the "current" is set to a debug sanity value.
Do you plan to send the series to add support for 32-bit userspace on
64-bits kernels for Xen 4.5?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-09-08 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 16:32 [PATCH v2] xen/arm: Correctly support WARN_ON Julien Grall
2014-09-08 13:01 ` Ian Campbell
2014-09-08 19:19 ` Julien Grall
2014-09-08 19:24 ` Julien Grall [this message]
2014-09-09 9:19 ` Ian Campbell
2014-09-09 20:25 ` Julien Grall
2014-09-09 9:17 ` Ian Campbell
2014-09-09 18:31 ` Julien Grall
2014-09-10 9:35 ` Ian Campbell
2014-09-10 19:02 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E0258.8040702@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).