From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] xen/arm: Correctly support WARN_ON Date: Mon, 08 Sep 2014 12:24:08 -0700 Message-ID: <540E0258.8040702@linaro.org> References: <1407256336-11839-1-git-send-email-julien.grall@linaro.org> <1410181281.3680.3.camel@kazak.uk.xensource.com> <540E0128.8070506@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XR4Xt-0003EO-D1 for xen-devel@lists.xenproject.org; Mon, 08 Sep 2014 19:24:13 +0000 Received: by mail-qg0-f50.google.com with SMTP id z60so798834qgd.9 for ; Mon, 08 Sep 2014 12:24:10 -0700 (PDT) In-Reply-To: <540E0128.8070506@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 08/09/14 12:19, Julien Grall wrote: >> >> OOI what is the size increase of the final (stripped) binary with this >> patch? > > I compared the file xen/xen and on both arm32/arm64 the binary is > smaller of about 2%. > > I think this is because previously gcc wasn't merge the string when > BUG_ON was used in inline function. BTW this series won't work correctly because of XSA-102 on ARM64 when WARN_ON/BUG_ON/ASSERT is used in startup code. This is because the "current" is set to a debug sanity value. Do you plan to send the series to add support for 32-bit userspace on 64-bits kernels for Xen 4.5? Regards, -- Julien Grall