From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC 3/9] xen: arm: handle concatenated root tables in dump_pt_walk Date: Mon, 08 Sep 2014 13:54:27 -0700 Message-ID: <540E1783.3060709@linaro.org> References: <3ef2b68c511f3e31de409b76757b95c78b99d750.1406728037.git.ian.campbell@citrix.com> <53D92423.3000509@linaro.org> <1409841622.10156.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409841622.10156.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, vijay.kilari@gmail.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 04/09/14 07:40, Ian Campbell wrote: > On Wed, 2014-07-30 at 17:58 +0100, Julien Grall wrote: >>> - first = __map_domain_page(p2m->root); >>> - dump_pt_walk(first, addr, P2M_ROOT_LEVEL); >>> - unmap_domain_page(first); >>> + dump_pt_walk(page_to_maddr(p2m->root), addr, >> >> You can directly use p2m->vttbr and avoid to call page_to_maddr. > > Not quite since vttbr contains the vmid encoding. > > page_to_maddr is cheap enough for a debug path I think. Hmmm, right. Sorry for the noise. Regards, -- Julien Grall