From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk
Date: Mon, 08 Sep 2014 14:33:39 -0700 [thread overview]
Message-ID: <540E20B3.4010401@linaro.org> (raw)
In-Reply-To: <b808d8e29fafb8cb80ed3563cc749b575832db53.1409847257.git.ian.campbell@citrix.com>
Hi Ian,
I forgot one point on my previous mail.
On 04/09/14 09:14, Ian Campbell wrote:
> - if ( first_table_offset(addr) >= LPAE_ENTRIES )
> - return;
> + mappings[root_level] = root;
> +
> + for ( level = root_level; ; level++ )
> + {
I would add the check "level < 3" or an ASSERT in the beginning of the
loop. So we could catch a possible overflow on offsets later if someone
decide to modify it.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-09-08 21:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 16:13 [PATCH v2 0/9] xen: arm: support for > 40-bit physical addressing Ian Campbell
2014-09-04 16:14 ` [PATCH v2 1/9] xen: arm: rename p2m->first_level to p2m->root Ian Campbell
2014-09-04 16:14 ` [PATCH v2 2/9] xen: arm: Implement variable levels in dump_pt_walk Ian Campbell
2014-09-08 21:24 ` Julien Grall
2014-09-08 22:12 ` Julien Grall
2014-09-09 15:04 ` Ian Campbell
2014-09-09 15:08 ` Ian Campbell
2014-09-09 16:04 ` Andrew Cooper
2014-09-08 21:33 ` Julien Grall [this message]
2014-09-04 16:14 ` [PATCH v2 3/9] xen: arm: handle concatenated root tables " Ian Campbell
2014-09-08 21:43 ` Julien Grall
2014-09-04 16:14 ` [PATCH v2 4/9] xen: arm: move setup_virt_paging to p2m.[ch] from mm.[ch] Ian Campbell
2014-09-04 16:14 ` [PATCH v2 5/9] xen: arm: Defer setting of VTCR_EL2 until after CPUs are up Ian Campbell
2014-09-08 21:46 ` Julien Grall
2014-09-04 16:14 ` [PATCH v2 6/9] xen: arm: handle variable p2m levels in p2m_lookup Ian Campbell
2014-09-08 22:05 ` Julien Grall
2014-09-04 16:14 ` [PATCH v2 7/9] xen: arm: handle variable p2m levels in apply_p2m_changes Ian Campbell
2014-09-05 23:32 ` Arianna Avanzini
2014-09-08 8:59 ` Ian Campbell
2014-09-08 22:22 ` Julien Grall
2014-09-04 16:14 ` [PATCH v2 8/9] xen: arm: support for up to 48-bit physical addressing on arm64 Ian Campbell
2014-09-08 23:28 ` Julien Grall
2014-09-04 16:14 ` [PATCH v2 9/9] xen: arm: support for up to 48-bit IPA " Ian Campbell
2014-09-08 23:42 ` Julien Grall
2014-09-08 21:05 ` [PATCH v2 1/9] xen: arm: rename p2m->first_level to p2m->root Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E20B3.4010401@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).